Skip to content

Commit d61ee16

Browse files
committed
Fixed bug of NotificationsActivity.
1 parent b25e6f8 commit d61ee16

File tree

4 files changed

+13
-5
lines changed

4 files changed

+13
-5
lines changed

app/src/main/java/com/lincanbin/carbonforum/NotificationsActivity.java

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import android.support.v7.widget.LinearLayoutManager;
1818
import android.support.v7.widget.RecyclerView;
1919
import android.support.v7.widget.Toolbar;
20+
import android.util.Log;
2021
import android.view.LayoutInflater;
2122
import android.view.MenuItem;
2223
import android.view.View;
@@ -207,7 +208,7 @@ public GetNotificationsTask(int type,
207208
int targetPage) {
208209
this.targetPage = targetPage;
209210
this.type = type;
210-
this.keyName = type == 1 ? "MentionArray" : "ReplyArray";
211+
this.keyName = type == 1 ? "ReplyArray" : "MentionArray";
211212
this.loadFromCache = loadFromCache;
212213
this.mSwipeRefreshLayout = mSwipeRefreshLayout;
213214
this.mRecyclerView = mRecyclerView;
@@ -230,6 +231,9 @@ public void run() {
230231
protected void onPostExecute(JSONObject jsonObject) {
231232
super.onPostExecute(jsonObject);
232233
int status = 0;
234+
if(loadFromCache){
235+
status = 1;
236+
}
233237
//先保存缓存
234238
if(jsonObject != null && !loadFromCache){
235239
try {
@@ -249,12 +253,15 @@ protected void onPostExecute(JSONObject jsonObject) {
249253
//防止异步任务未完成时,用户按下返回,Fragment被GC,造成NullPointer
250254
if(mRecyclerView != null && mSwipeRefreshLayout !=null && mAdapter != null && rootView != null && getActivity() != null) {
251255
mSwipeRefreshLayout.setRefreshing(false);
252-
if (list != null && status == 1) {
253-
if(!list.isEmpty()){
256+
Log.d("Status : ", keyName + String.valueOf(status));
257+
if (status == 1) {
258+
if(list != null && !list.isEmpty()){
259+
Log.d("Action : ", keyName + " SetData");
254260
mAdapter.setData(list);
255261
mAdapter.notifyDataSetChanged();
256262
}else{
257-
//TODO: 新注册用户,网络正常但是当前无任何通知,准备做个提示
263+
//新注册用户,网络正常但是当前无任何通知,准备做个提示
264+
Snackbar.make(rootView, R.string.empty_notification, Snackbar.LENGTH_LONG).setAction("Action", null).show();
258265
}
259266
} else {
260267
Snackbar.make(rootView, R.string.network_error, Snackbar.LENGTH_LONG).setAction("Action", null).show();

app/src/main/res/layout/activity_notifications.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
android:id="@+id/appbar"
1414
android:layout_width="match_parent"
1515
android:layout_height="wrap_content"
16-
android:paddingTop="@dimen/appbar_padding_top"
1716
android:theme="@style/AppTheme.AppBarOverlay">
1817

1918
<android.support.v7.widget.Toolbar

app/src/main/res/values-zh-rCN/strings_activity_notifications.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,5 @@
33
<string name="title_activity_notifications">消息提醒</string>
44
<string name="notifications_replied_to_me">提到我的</string>
55
<string name="notifications_mentioned_me">回复我的</string>
6+
<string name="empty_notification">暂无任何通知</string>
67
</resources>

app/src/main/res/values/strings_activity_notifications.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,5 @@
33
<string name="title_activity_notifications">Notifications</string>
44
<string name="notifications_replied_to_me">Replied To Me</string>
55
<string name="notifications_mentioned_me">Mentioned Me</string>
6+
<string name="empty_notification">Currently there is no any notification</string>
67
</resources>

0 commit comments

Comments
 (0)